Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort log spacemap tunables in alphabetical order #9143

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Sort log spacemap tunables in alphabetical order #9143

merged 1 commit into from
Aug 12, 2019

Conversation

sdimitro
Copy link
Contributor

@sdimitro sdimitro commented Aug 8, 2019

Beside the whole commit being a nit in reality it should
bring the diffs of the spa_log_spacemap.c source file
between ZoL and delphix/zfs to 0.

Signed-off-by: Serapheim Dimitropoulos [email protected]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@sdimitro
Sort log spacemap tunables in alphabetical order
70d3df9 
Beside the whole commit being a nit in reality it should
bring the diffs of the spa_log_spacemap.c source file
between ZoL and delphix/zfs to 0.

Signed-off-by: Serapheim Dimitropoulos <[email protected]>
chrisrd
chrisrd approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@chrisrd chrisrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 9, 2019 •
edited
Loading

Codecov Report

Merging #9143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9143   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files         400      400           
  Lines      121692   121692           
=======================================
  Hits        96360    96360           
  Misses      25332    25332
Flag Coverage Δ
#kernel 79.72% <ø> (+0.05%) ⬆️
#user 67.18% <ø> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81f179...70d3df9. Read the comment docs.

@sdimitro sdimitro added the Status: Accepted Ready to integrate (reviewed, tested) label Aug 12, 2019
@behlendorf behlendorf merged commit 2081db7 into openzfs:master Aug 12, 2019
allanjude pushed a commit to KlaraSystems/zfs that referenced this pull request Apr 28, 2020
@sdimitro
Sort log spacemap tunables in alphabetical order
5a38b3e 
Beside the whole commit being a nit in reality it should
bring the diffs of the spa_log_spacemap.c source file
between ZoL and delphix/zfs to 0.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Chris Dunlop <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes openzfs#9143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@chrisrd chrisrd chrisrd approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdimitro @behlendorf @chrisrd @gmelikov